Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github release configuration #162

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

anders-larsson
Copy link
Contributor

Add Github release configuration to automatically exclude PRs with tag exclude-changelog. This tag would also need to be excluded when running github_changelog_generator to generate CHANGELOG.md.

Should we use this tag och change it to something else? Github's documentation uses ignore-for-release. Maybe that is better.

Copy link
Contributor

@Phil-Friderici Phil-Friderici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have never fiddled around with Github release configuration.
What's the use case of this ?

@anders-larsson
Copy link
Contributor Author

When you create a new release on Github you can have it automatically generate a change log for you, based on the PRs since the last tag. See https://github.com/Ericsson/puppet-module-vas/releases/tag/v1.1.0 for example. This would let us add a label to PRs that we want excluded from the release notes like the release commit itself (#158 in this case)

@anders-larsson
Copy link
Contributor Author

If we want to enable branch protection, all changes would need to come from PRs. So this is simply to prevent such PRs from being added to Release notes automatically.

@Phil-Friderici
Copy link
Contributor

Well, that sounds not too bad. We should give it a try.

@anders-larsson
Copy link
Contributor Author

Changed label to ignore-for-release.

@anders-larsson anders-larsson merged commit 349264d into Ericsson:master Feb 28, 2024
3 checks passed
@anders-larsson anders-larsson deleted the release_config branch February 28, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants