Implement Dynamic Jolokia Notification Listener #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorCavichioli
requested review from
ch1bbe,
tommystendahl,
paulchandler,
jwaeab and
SajidRiaz138
SajidRiaz138
previously approved these changes
Jan 7, 2025
SajidRiaz138
previously approved these changes
Jan 7, 2025
tommystendahl
requested changes
Jan 8, 2025
jwaeab
reviewed
Jan 8, 2025
...ain/java/com/ericsson/bss/cassandra/ecchronos/core/impl/jmx/http/ClientRegisterResponse.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ericsson/bss/cassandra/ecchronos/core/impl/jmx/http/ClientRegisterResponse.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ericsson/bss/cassandra/ecchronos/core/impl/jmx/http/ClientRegisterResponse.java
Outdated
Show resolved
Hide resolved
jwaeab
approved these changes
Jan 9, 2025
tommystendahl
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jolokia 2, it is possible to create notification listeners using JavaScript or JSON. Currently, a RepairTask is an implementation of NotificationListener. However, when using Jolokia, it is not possible to add the listener using the traditional method:
This approach is not supported by Jolokia.
The purpose of this pull request is to reconcile the current method of adding notification listeners in Jolokia with the RepairTask. Integration tests for this functionality will be implemented in a separate pull request.
Closes #831