Separate serial consistency configuration from remoteRouting functionality - Issue #633 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorCavichioli
force-pushed
the
remot-routing-fix
branch
from
29702cd to
f857635
Compare
masokol
reviewed
Feb 19, 2024
VictorCavichioli
force-pushed
the
remot-routing-fix
branch
from
f857635 to
8666fd3
Compare
It's an enhancement but as we discusses we will create another PR to ecchronos 4.x and merge first |
VictorCavichioli
force-pushed
the
remot-routing-fix
branch
from
8666fd3 to
3364199
Compare
To decouple the consistency definition in lightweight transactions, introduce a new property configurable by ecc.yml that allows consistency to be overridden by the values DEFAULT/SERIAL/LOCAL. Closes Ericsson#633
VictorCavichioli
force-pushed
the
remot-routing-fix
branch
from
3364199 to
b6d105f
Compare
masokol
reviewed
Feb 19, 2024
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/AbstractCassandraTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/TestCASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/TestCASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/TestCASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/TestCASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/TestCASLockFactory.java
Outdated
Show resolved
Hide resolved
...com/ericsson/bss/cassandra/ecchronos/core/repair/TestDefaultRepairConfigurationProvider.java
Outdated
Show resolved
Hide resolved
masokol
reviewed
Feb 20, 2024
...ava/com/ericsson/bss/cassandra/ecchronos/application/config/connection/NativeConnection.java
Outdated
Show resolved
Hide resolved
masokol
reviewed
Feb 20, 2024
...ava/com/ericsson/bss/cassandra/ecchronos/application/config/connection/NativeConnection.java
Outdated
Show resolved
Hide resolved
...java/com/ericsson/bss/cassandra/ecchronos/connection/impl/LocalNativeConnectionProvider.java
Outdated
Show resolved
Hide resolved
...java/com/ericsson/bss/cassandra/ecchronos/connection/impl/LocalNativeConnectionProvider.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/utils/ConsistencyType.java
Outdated
Show resolved
Hide resolved
VictorCavichioli
force-pushed
the
remot-routing-fix
branch
from
fa68383 to
c35da29
Compare
masokol
reviewed
Feb 21, 2024
...cation/src/test/java/com/ericsson/bss/cassandra/ecchronos/application/config/TestConfig.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/CASLockFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/TestCASLockFactory.java
Show resolved
Hide resolved
VictorCavichioli
changed the title
|
LGTM |
jwaeab
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To decouple the consistency definition in lightweight transactions, introduce a new property configurable by ecc.yml that allows consistency to be overridden by the values DEFAULT/SERIAL/LOCAL.
Closes #633