Incremental parsing issue fixes #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isSingletonResult instead to dbutil.
dbukki
changed the title
dbukki
added
Kind: Bug ⚠️
Plugin: C++
mcserep
requested changes
Apr 28, 2024
There was a problem hiding this comment.
In case this size() == 1 is the only conflicting code part with SQLite, then we can keep its support with your proposed solution. However, the C++ LSP service plugin also contains usages of the size() method in ODB query results. Probably those should be fixed, too.
It should be documented in the code why not to use the size() method in these cases.
mcserep
previously approved these changes
May 8, 2024
|
Looks good to me! I had to resolve a merge conflict, so now my approval is not enough as the last commiter. @intjftw Please approve it as well (review it too of course, if you would like 😄 )! |
mcserep
force-pushed
the
incremental-remedies
branch
from
de77e87 to
429490e
Compare
intjftw
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #735
In accordance with the diagnosis outlined in #735 (comment) , the following fixes have been made:
CppAstNodeMetricsFileViewdb view has been added to manage the AST node ID <-> File ID association (_astNodeIdCache) inCppMetricsParser::CppMetricsParser..size()call inSourceManager::removeFilehas been replaced by a newisSingletonResulthelper function in dbutil.