Efferent coupling of types #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intjftw
added
Kind: Enhancement 🌟
Status: WIP 👷
mcserep
requested changes
Apr 8, 2024
| @@ -1,4 +1,5 @@ | |||
| #include <cppmetricsparser/cppmetricsparser.h> | |||
| #include "efferent.h" | |||
There was a problem hiding this comment.
Incorrect inclusion order. Please refer to the coding conventions.
| @@ -8,6 +8,7 @@ include_directories( | |||
| ${PLUGIN_DIR}/model/include) | |||
|
|
|||
| add_library(cxxmetricsparser SHARED | |||
| src/efferent.cpp | |||
There was a problem hiding this comment.
efferent.h should also be added here, so CMake can recognize that in case the header file changes, recompilation of the target is required.
1 task
…g to the cpp metrics service.
intjftw
removed
the
Status: WIP 👷
|
I complemented the calculation with inherited types, member function parameter types and member function local variable types, aside from the already calculated member field types. |
mcserep
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #673. I'd like to include multiple related tasks, hence the WIP label.
Refactoring of the C++ metrics plugin: organize metrics calculating functions into separate source files.Should be separate PR.
Test cases for efferent coupling.