refactor: update mapError to take in Err and spit out Err

EpicenterHQ · Dec 24, 2024 · 35dbcdd · 35dbcdd
1 parent fa19c4c
commit 35dbcdd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/violet-ducks-know.md b/.changeset/violet-ducks-know.md
@@ -0,0 +1,5 @@
+---
+"@epicenterhq/result": patch
+---
+
+Update mapError to take in Err and spit out Err
diff --git a/src/result.ts b/src/result.ts
@@ -28,13 +28,13 @@ export function trySync<T, E>({
 	mapErr,
 }: {
 	try: () => T extends Promise<unknown> ? never : T;
-	mapErr: (error: unknown) => E;
+	mapErr: (error: Err<unknown>) => Err<E>;
 }): Result<T, E> {
 	try {
 		const data = operation();
 		return Ok(data);
 	} catch (error) {
-		return Err(mapErr(error));
+		return mapErr(Err(error));
 	}
 }
 
@@ -43,12 +43,12 @@ export async function tryAsync<T, E>({
 	mapErr,
 }: {
 	try: () => Promise<T>;
-	mapErr: (error: unknown) => E;
+	mapErr: (error: Err<unknown>) => Err<E>;
 }): Promise<Result<T, E>> {
 	try {
 		const data = await operation();
 		return Ok(data);
 	} catch (error) {
-		return Err(mapErr(error));
+		return mapErr(Err(error));
 	}
 }
diff --git a/src/services.ts b/src/services.ts
@@ -9,11 +9,11 @@ type ServiceErrorFns<ServiceErrorProperties> = {
 	Err: (props: ServiceErrorProperties) => Err<ServiceErrorProperties>;
 	trySync: <T>(opts: {
 		try: () => T extends Promise<unknown> ? never : T;
-		mapErr: (error: unknown) => ServiceErrorProperties;
+		mapErr: (error: Err<unknown>) => Err<ServiceErrorProperties>;
 	}) => Result<T, ServiceErrorProperties>;
 	tryAsync: <T>(opts: {
 		try: () => Promise<T>;
-		mapErr: (error: unknown) => ServiceErrorProperties;
+		mapErr: (error: Err<unknown>) => Err<ServiceErrorProperties>;
 	}) => Promise<Result<T, ServiceErrorProperties>>;
 };