CMDCT-4105 - adds raw output to jq for consistency and non-breaking when we add playwright #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peoplespete
requested review from
BearHanded,
braxex and
ailZhou
as code owners
peoplespete
force-pushed
the
cmdct-4105-redo
branch
from
d2de3d5 to
8a62a56
Compare
JonHolman
previously approved these changes
Jan 21, 2025
peoplespete
force-pushed
the
cmdct-4105-redo
branch
3 times, most recently
from
b7ad3e4 to
d1b634a
Compare
…hen we add playwright
peoplespete
force-pushed
the
cmdct-4105-redo
branch
from
d1b634a to
9e3aded
Compare
JonHolman
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this description:
#2536 (comment)
The only thing of note here is adding --raw-output to the jq call so that there is no quotes in the env variable which causes playwright problems. This came up while upgrading HCBS and so I'd like it fixed here so that we don't have it come back up when we add playwright to seds and it just keeps the files matching across repos which is a nice to have.
I also snuck in a removal of the env variable for serverless v4 since @JonHolman correctly pointed out does nothing.