Remove signup email configuration, unused, revert to default account #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BearHanded
requested review from
berryd,
dwhitestratiform,
karla-vm and
ailZhou
dwhitestratiform
approved these changes
Feb 21, 2024
berryd
approved these changes
Feb 21, 2024
|
Code Climate has analyzed commit c9a82fc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 73.1%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove a chunk of the logic about where emails come from when signing up in cognito. This functionality is no longer used in seds, all test accounts in lower envs are created via seeding.
Proved it worked in SEDS PR.
The stream functions service still references the ssm params for these emails, but not the ARNs and should continue to deploy fine. The functions there that trigger emails already do not work and are likely dead code, but I am in the process of verifying that officially.
This will unblock deployments for now.
Related ticket(s)
How to test
Important updates
Author checklist
convert to a different template: test → val | val → prod