Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPM - Describe Rate Validation #2050

Merged
merged 3 commits into from
Feb 14, 2024
Merged

OPM - Describe Rate Validation #2050

merged 3 commits into from
Feb 14, 2024

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Feb 13, 2024

Description

The entering Other Performance Measure, there is no validation for checking whether the user had provided a description for the rate. This PR adds a validation to trigger when the textbox is empty.
Screenshot 2024-02-13 at 3 07 20 PM

New validation message
Screenshot 2024-02-13 at 11 46 29 AM

Related ticket(s)

CMDCT-3293


How to test

  1. Sign into QMR
  2. Select any coreset where [Measurement Specification] has an [Other] radio button.
  3. Select [Other] to enable the Other Performance Measure section
  4. Try to validate without filling out the rate description
  5. The validation error message from above should show up
  6. Fill out the rate description textbox and validate again
  7. The message should go away

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Feb 13, 2024

Code Climate has analyzed commit 58fa398 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 73.1% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou added ready for review Ready for all the reviews! product review Waiting for product review labels Feb 13, 2024
Copy link
Contributor

@BearHanded BearHanded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the deployed branch, does what it says on the box.

@ailZhou ailZhou removed the product review Waiting for product review label Feb 14, 2024
@ailZhou ailZhou merged commit 8639a17 into master Feb 14, 2024
170 checks passed
@ailZhou ailZhou deleted the cmdct-3293-val-error branch February 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants