Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify qmr api gateway waf to utilize the enterprise cmcs waf plugin #2045

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

dwhitestratiform
Copy link
Contributor

@dwhitestratiform dwhitestratiform commented Feb 1, 2024

Description

currently qmr api gateway waf is only applying one rule to the waf rules, this PR aims to utilize the enterprise cmcs waf plugin to use a standard set of waf rules for the api gateway waf

Related ticket(s)

none


How to test

ensure the application works as expected after deploy
look in aws console at the api gateway waf rules to ensure expected rules are in place
endpoint:
https://d2ggnbwzcfgjcw.cloudfront.net/

Important updates

may need to delete old waf by hand after deploy ... TBD for master


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Feb 1, 2024

Code Climate has analyzed commit a47783f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 73.1% (0.0% change).

View more on Code Climate.

@BearHanded BearHanded merged commit f376264 into master Feb 1, 2024
112 of 113 checks passed
@BearHanded BearHanded deleted the app-api-waf-fix branch February 1, 2024 15:12
@dwhitestratiform dwhitestratiform removed the ready for review Ready for all the reviews! label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants