Rename existing WAF to fix existing environment build failure #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwhitestratiform
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
|
Code Climate has analyzed commit 56ac197 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 73.1% (0.0% change). View more on Code Climate. |
BearHanded
approved these changes
Jan 23, 2024
berryd
approved these changes
Jan 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upon merging to the main integration branch (in QMR's case master) the deploy failed updating the WAF with the following error.
Error: CREATE_FAILED: WafPluginAcl (AWS::WAFv2::WebACL) Resource handler returned message: "AWS WAF couldn?t perform the operation because some resource in your request is a duplicate of an existing one. (Service: Wafv2, Status Code: 400, Request ID: 24371deb-7bc0-42ba-a855-12bec4e67b5b)" (RequestToken: 30c004da-370d-38d2-3561-be2fc9a79ea4, HandlerErrorCode: AlreadyExists)This PR is to rename the waf to a unique name to allow the deploy to run through successfully.
Related ticket(s)
https://jiraent.cms.gov/browse/CMDCT-2942
How to test
Merge and verify deploy runs through cleanly in the master branch as well as go to aws console and verify the rename
Important updates
upon success copy this PR over to the exiting PR so it is not lost for updating other products.
#2036
Author checklist
convert to a different template: test → val | val → prod