-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure Lower QMR Environments #2017
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 20cc32e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 73.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The team has been requested to restrict lower environments to be restricted from public access and to require using cms vpn to access.
This pull request utilizes the cmcs waf plugin to apply standard firewall rules used at cms. See this link to see standard rules inherited from the plugin.
In addition to the inherited rules a new rule is applied in this PR named "vpn-only" that its default action is to restrict all access with the exception to the IP's defined in the qmr dev account ip set.
In addition the ui serverless.yaml is where we can conditionally set if the environment is restricted. Currently it's set to a default value of restricted, with dev (master) and val also restricted and prod unrestricted per requirements of qmr being accessible to state users.
Related ticket(s)
How to test
in a new cognito browser session visit the application endpoint for this branch both on VPN and not on VPN to confirm access or lack there of when not on VPN.
Important updates
development environments will not be accessible unless on VPN.
Author checklist
convert to a different template: test → val | val → prod