Fixing QMR Favicon to be consistent with other MDCT Applications #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwhitestratiform
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
|
Code Climate has analyzed commit 5374eed and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 73.4% (0.0% change). View more on Code Climate. |
gmrabian
approved these changes
Dec 4, 2023
BearHanded
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In doing some debugging and general familiarization with the QMR application one of the first things I noticed was the Favicon was not that of MDCT but rather a previous contractor. This PR aims to fix that by following patterns of MCR and MFP (see links below)
https://github.com/Enterprise-CMCS/macpro-mdct-mcr/blob/main/services/ui-src/public/index.html
https://github.com/Enterprise-CMCS/macpro-mdct-mfp/blob/main/services/ui-src/public/index.html
Related ticket(s)
https://jiraent.cms.gov/browse/CMDCT-3090
How to test
Important updates
N/A
Author checklist
convert to a different template: test → val | val → prod