-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor amplify methods to single file #801
Conversation
Code Climate has analyzed commit 10b8e9f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.8% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! ⭐
Description
Amplify typically has breaking changes with each version upgrade. To mitigate how much refactoring we have to do with each upgrade, we should use generic helpers and call amplify methods from a single file, as much as possible.
Other changes in this PR:
atob
andbtoa
Related ticket(s)
CMDCT-4037
How to test
Notes
Left in uses of
AnyObject
where there's aTODO
to replace them. Because of that, I needed to cast toReportShape
in a couple of places. I putTODO
s as a reminder to remove the casting when theAnyObject
conversion happens.Pre-review checklist