More Playwright tinkerings #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessabean
force-pushed
the
je-flaky-test
branch
from
f424e43 to
47b2823
Compare
gmrabian
previously approved these changes
Nov 7, 2024
|
Code Climate has analyzed commit ca03930 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.2% (0.0% change). View more on Code Climate. |
gmrabian
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
tests pass! I'm wondering if we can use the blur function that doesn't use a timeout from cmsds?
it looks like timeout is only for the onComponentBlur function. Any way we could just use onBlur? cmsds component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related ticket(s)
CMDCT-
How to test