Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format aria labels for PDF table headers #652

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

jessabean
Copy link
Contributor

@jessabean jessabean commented Jun 14, 2024

Description

Adds aria-labels with full-length entity names for the truncated PDF table headers. Currently only impacts the target population headings for Transition Benchmarks in the Work Plan.

Related ticket(s)

CMDCT-3682


How to test

Link: https://d2yjt98l5zoxbx.cloudfront.net/

  • Create a work plan
  • Go straight to the Review & Submit section and view the PDF page.
  • In the "Transition Benchmark Totals" section, the table headers for default populations should be abbreviated
  • Inspect the source code for the table headers. Each th should have an aria-label attribute and it should contain the full text for the header.
Screenshot 2024-06-14 at 10 36 17 AM Screenshot 2024-06-14 at 10 37 48 AM

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@jessabean jessabean added the design review Waiting for design review label Jun 14, 2024
Copy link

codeclimate bot commented Jun 14, 2024

Code Climate has analyzed commit dc26bd2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.3% (90% is the threshold).

This pull request will bring the total coverage in the repository to 92.4%.

View more on Code Climate.

@jessabean jessabean added ready for review Ready for all the reviews! labels Jun 14, 2024
@jessabean jessabean marked this pull request as ready for review June 14, 2024 20:28
Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good

@jessabean jessabean merged commit 6e96102 into main Jun 21, 2024
21 checks passed
@jessabean jessabean deleted the cmdct-3682-pdf-tables branch June 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design review Waiting for design review ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants