-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmdct 3662 - remove button from inside link #649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this in MCR as well?
@gmrabian yeah, I can see if there's already a card for it, if not I'll make one |
Code Climate has analyzed commit 2429770 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 92.4% (0.0% change). View more on Code Climate. |
Description
The "Leave form" call to action should be marked up as a link and there should be no element inside.
The "Leave form" call to action should be styled as an outline button
original:
Related ticket(s)
CMDCT-3662
How to test
Login, create WP, enter WP and see that 'Leave form' still looks the same but is no longer a
button
.Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod