Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdct 3662 - remove button from inside link #649

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Cmdct 3662 - remove button from inside link #649

merged 5 commits into from
Jun 14, 2024

Conversation

britt-mo
Copy link
Contributor

@britt-mo britt-mo commented Jun 13, 2024

Description

The "Leave form" call to action should be marked up as a link and there should be no element inside.
The "Leave form" call to action should be styled as an outline button

original:

Screenshot 2024-06-13 at 9 53 17 AM

Related ticket(s)

CMDCT-3662


How to test

Login, create WP, enter WP and see that 'Leave form' still looks the same but is no longer a button.

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

gmrabian
gmrabian previously approved these changes Jun 13, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this in MCR as well?

@britt-mo
Copy link
Contributor Author

do we need this in MCR as well?

@gmrabian yeah, I can see if there's already a card for it, if not I'll make one

@britt-mo britt-mo requested a review from gmrabian June 13, 2024 18:40
@britt-mo britt-mo added the ready for review Ready for all the reviews! label Jun 13, 2024
@britt-mo britt-mo requested a review from jessabean June 14, 2024 16:35
Copy link

codeclimate bot commented Jun 14, 2024

Code Climate has analyzed commit 2429770 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 92.4% (0.0% change).

View more on Code Climate.

@britt-mo britt-mo merged commit 402e450 into main Jun 14, 2024
19 checks passed
@britt-mo britt-mo deleted the cmdct-3662 branch June 14, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants