bugfix: display WP topic on the export page

Enterprise-CMCS · Dec 19, 2024 · c982db1 · c982db1
1 parent ad27cf3
commit c982db1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 25 deletions.
diff --git a/services/ui-src/src/components/export/ExportedModalOverlayReportSection.test.tsx b/services/ui-src/src/components/export/ExportedModalOverlayReportSection.test.tsx
@@ -6,7 +6,6 @@ import {
 } from "utils/testing/setupJest";
 import {
   mockSARReportWithOverlays,
-  mockWPReportWithOtherTypeOverlays,
   mockWPReportWithOverlays,
 } from "utils/testing/mockReport";
 import {
@@ -336,9 +335,10 @@ describe("<ExportedModalOverlayReportSection />", () => {
   test("should render correct initiative topic", () => {
     mockedUseStore.mockReturnValue({
       ...mockReportStore,
-      report: mockWPReportWithOtherTypeOverlays,
+      report: mockWPReportWithOverlays,
     });
     render(testComponent(wpMockProps));
+    expect(screen.getByText("mock WP topic")).toBeInTheDocument();
     expect(screen.getByText("Unique initiative type")).toBeInTheDocument();
   });
 

diff --git a/services/ui-src/src/components/export/ExportedModalOverlayReportSection.tsx b/services/ui-src/src/components/export/ExportedModalOverlayReportSection.tsx
@@ -164,8 +164,9 @@ export function renderModalOverlayTableBody(
                   {`${idx + 1}. ${entity.initiative_name}` ?? "Not entered"}
                 </Heading>
                 <Text sx={sx.headingSubtitle}>
-                  {entity.initiative_wp_otherTopic ??
-                    entity.initiative_wpTopic[0].value}
+                  {entity.initiative_wp_otherTopic
+                    ? entity.initiative_wp_otherTopic
+                    : entity.initiative_wpTopic[0].value}
                 </Text>
               </Box>
             </Flex>

diff --git a/services/ui-src/src/utils/testing/mockReport.ts b/services/ui-src/src/utils/testing/mockReport.ts
@@ -496,6 +496,18 @@ export const mockWPReportWithOverlays = {
           },
         ],
       },
+      {
+        ...mockWPFullReport.fieldData.entityType[0],
+        type: OverlayModalTypes.INITIATIVE,
+        id: "mock wip id",
+        initiative_wpTopic: [
+          {
+            key: "other-type-key",
+            value: "Other, specify",
+          },
+        ],
+        initiative_wp_otherTopic: "Unique initiative type",
+      },
     ],
   },
   formTemplate: {
@@ -520,27 +532,6 @@ export const mockWPReportWithOverlays = {
   },
 };
 
-export const mockWPReportWithOtherTypeOverlays = {
-  ...mockWPFullReport,
-  fieldData: {
-    ...mockWPFullReport.fieldData,
-    [OverlayModalTypes.INITIATIVE]: [
-      {
-        ...mockWPFullReport.fieldData.entityType[0],
-        type: OverlayModalTypes.INITIATIVE,
-        id: "mock wip id",
-        initiative_wpTopic: [
-          {
-            key: "other-type-key",
-            value: "Other, specify",
-          },
-        ],
-        initiative_wp_otherTopic: "Unique initiative type",
-      },
-    ],
-  },
-};
-
 export const mockSARReportWithOverlays = {
   ...mockSARFullReport,
   fieldData: {