Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serverless version installed by package.json #12022

Closed
wants to merge 1 commit into from

Conversation

bangbay-bluetiger
Copy link
Contributor

Description

Our apps are set up to use a global version of serverless. Since there can only be one version of a package installed globally, it's causing apps to fail if they're not on the same version. Particularly with serverless, there doesn't seem to be a reason to use a global version when the apps install a version of serverless locally. This PR:

  • Updates ./run local to use the local serverless binary
  • Removes global installation of serverless

How to test

  1. Run ./run local
  2. App should boot normally

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Copy link

codeclimate bot commented Jan 27, 2025

Code Climate has analyzed commit 6ff8ac5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@bangbay-bluetiger bangbay-bluetiger marked this pull request as ready for review January 28, 2025 00:05
@JonHolman
Copy link
Contributor

We can do this, but I will be opening a PR very soon (maybe today, at least tomorrow morning to undo this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants