Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QMS - Update General Information Page #101

Merged
merged 1 commit into from
Jan 30, 2025
Merged

QMS - Update General Information Page #101

merged 1 commit into from
Jan 30, 2025

Conversation

ajaitasaini
Copy link
Contributor

@ajaitasaini ajaitasaini commented Jan 30, 2025 •
edited
Loading

Description

General Info page has been updated, these changes reflect the new design

Related ticket(s)

CMDCT-4235

How to test

  1. Login, create report, navigate to general info page. Should now look like this:
Screenshot 2025-01-30 at 9 54 35 AM

For a more detailed view of new design, here is the Figma link: https://www.figma.com/design/B8IEoYKQ7DuQyx5nStls8F/HCBS?node-id=357-10299&t=eUWseNW7cfV1Xvla-0

Important updates

Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 30, 2025

Code Climate has analyzed commit e94662a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 93.9% (0.0% change).

View more on Code Climate.

@ajaitasaini ajaitasaini marked this pull request as ready for review January 30, 2025 15:01
rocio-desantiago
rocio-desantiago approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rocio-desantiago rocio-desantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smallest PR to review ✅
Checked Deploy and showing up as expected on General Information page.

@ajaitasaini ajaitasaini merged commit 0147b03 into main Jan 30, 2025
23 checks passed
@ajaitasaini ajaitasaini deleted the updategeninfopage branch January 30, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocio-desantiago rocio-desantiago rocio-desantiago approved these changes

@benmartin-coforma benmartin-coforma benmartin-coforma approved these changes

@BearHanded BearHanded Awaiting requested review from BearHanded BearHanded is a code owner

@braxex braxex Awaiting requested review from braxex braxex is a code owner

@peoplespete peoplespete Awaiting requested review from peoplespete

@angelaco11 angelaco11 Awaiting requested review from angelaco11

@ailZhou ailZhou Awaiting requested review from ailZhou

Assignees

@ajaitasaini ajaitasaini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaitasaini @rocio-desantiago @benmartin-coforma