-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eleven mask script to run on 2020 and 2021 #139841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 24537 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 24547 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 0fbd482 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 81.1% (0.0% change). View more on Code Climate. |
When I try to run the second Dynamo command I'm getting a node error:
But doing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 IT WORKS!
In case anyone comes across this error in the future, a node_modules folder deletion + running ./yarn (both of these actions being in the database folder) cleared it up :D |
Description
This ETL is a follow up to the <11 PR work and expands upon the removal of certain calculations in the print view as defined in this ticket. It goes through and adds the <11 mask to the 2021 and 2020 prior forms for all states for the exact same questions and removes a few calculations in sections 3 and 5. You can see a live before and after of running this script in the deployed environment here:
Screen.Recording.2024-10-16.at.11.08.03.AM.mov
Related ticket(s)
How to test
./run local
(To ensure a brand new, seeded database)DYNAMO_ENDPOINT=http://localhost:8000 dynamodb-admin
after the local environment has fully spun up.DYNAMODB_URL="http://localhost:8000" dynamoPrefix="local" node services/database/scripts/add-less-than-eleven-mask.js
Extra Credit
Pre-review checklist
Pre-merge checklist
Review