Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify sidevert #139832

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Amplify sidevert #139832

merged 4 commits into from
Nov 21, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Nov 20, 2024

Description

To address an issue with custom provider authentication...

Revert to amplify v5 while attempting to keep some of the good organizational changes (like moving all amplify stuff to one lib)

Related ticket(s)

CMDCT-4175


How to test

  • All tests pass
  • All api/auth stuff works

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

Copy link

codeclimate bot commented Nov 20, 2024

Code Climate has analyzed commit 4831413 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 96.3% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.3% (0.2% change).

View more on Code Climate.

@gmrabian gmrabian marked this pull request as ready for review November 20, 2024 18:59
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Nov 20, 2024
@ntsummers1
Copy link
Collaborator

image

@gmrabian gmrabian merged commit 00d8e84 into main Nov 21, 2024
21 checks passed
@gmrabian gmrabian deleted the amplify-sidevert branch November 21, 2024 14:59
ntsummers1 added a commit that referenced this pull request Nov 22, 2024
ntsummers1 added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants