Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify test2 #139831

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Amplify test2 #139831

merged 5 commits into from
Nov 19, 2024

Conversation

ntsummers1
Copy link
Collaborator

Description

Related ticket(s)

CMDCT-


How to test

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Nov 19, 2024

Code Climate has analyzed commit 18cc7f9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include the yarn.lock change too!

@ntsummers1 ntsummers1 marked this pull request as ready for review November 19, 2024 19:12
@ntsummers1
Copy link
Collaborator Author

include the yarn.lock change too!

Looks like its already a dep of AWS-amplify so its in the yarn lock? Thought I had to include it also

@ntsummers1 ntsummers1 merged commit d5d8acc into main Nov 19, 2024
23 checks passed
@ntsummers1 ntsummers1 deleted the amplify-test2 branch November 19, 2024 19:14
ntsummers1 added a commit that referenced this pull request Nov 22, 2024
ntsummers1 added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants