Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket CS2371782: Add global param to signout #139825

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Ticket CS2371782: Add global param to signout #139825

merged 1 commit into from
Nov 18, 2024

Conversation

ntsummers1
Copy link
Collaborator

@ntsummers1 ntsummers1 commented Nov 18, 2024

Description

[This user] selects the sign out link in CARTS and is taken to OKTA dashboard. He then selects the log out link from Okta and is routed to the IDM login screen, which suggests that he's logged out now from both CARTS and OKTA. But if the user enters the CARTS URL in the browser's address bar and presses Enter, he's taken right back into CARTS without being prompted to sign in. If the user then enters the IDM URL that shows that he is signed out of IDM because it prompted him to sign in, but if doesn't sign in at that point and then again enters the CARTS URL he's still able to access CARTS without another sign in. Same results after clearing cache in Chrome and same issue if using Firefox. Help desk is able to reproduce this behavior on multiple laptops in Chrome and Firefox.

We're going to attempt to fix this with the global signout param being passed. You can read more about that here: https://docs.amplify.aws/react/build-a-backend/auth/connect-your-frontend/sign-out/


How to test

See above. https://dmkyt4bm6nwc2.cloudfront.net/

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

@ntsummers1 ntsummers1 self-assigned this Nov 18, 2024
@ntsummers1 ntsummers1 added the draft Just a draft label Nov 18, 2024
Copy link

codeclimate bot commented Nov 18, 2024

Code Climate has analyzed commit 8785ed8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

@ntsummers1 ntsummers1 added ready for review Ready for all the reviews! and removed draft Just a draft labels Nov 18, 2024
@ntsummers1 ntsummers1 marked this pull request as ready for review November 18, 2024 19:27
@ntsummers1 ntsummers1 merged commit 8bfc845 into main Nov 18, 2024
23 checks passed
@ntsummers1 ntsummers1 deleted the global-signout branch November 18, 2024 19:32
ntsummers1 added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants