Fix storage config, add oauth import, remove unused dep #139811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 8d79d96 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 81.1% (0.0% change). View more on Code Climate. |
gmrabian
requested review from
BearHanded,
braxex and
ntsummers1
as code owners
gmrabian
requested review from
jessabean,
JonHolman,
britt-mo,
karla-vm and
bangbay-bluetiger
JonHolman
approved these changes
Oct 30, 2024
ntsummers1
added a commit
that referenced
this pull request
Nov 22, 2024
)" This reverts commit b7e2c23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final learnings from amplify upgrade. CARTS is already working, but keeping these for tidiness and consistency.
Related ticket(s)
CMDCT-4053
How to test
merge to main
ensure idm login still works
Pre-review checklist