Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for CMSHomepage #139509

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Add tests for CMSHomepage #139509

merged 1 commit into from
Nov 8, 2023

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Nov 6, 2023

Description

See title

About 300 of the line changes are yarn.lock. No need to be scared 😄


How to test

Tests pass


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary

Copy link

codeclimate bot commented Nov 6, 2023

Code Climate has analyzed commit b1f5185 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 64.7% (2.8% change).

View more on Code Climate.

@gmrabian gmrabian added the ready for review Ready for all the reviews! label Nov 6, 2023
Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed for me (after running yarn)

Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@benmartin-coforma benmartin-coforma merged commit d320384 into main Nov 8, 2023
14 checks passed
@benmartin-coforma benmartin-coforma deleted the test-cms-homepage branch November 8, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants