Remove styled-components package #139488
Merged
Remove styled-components package #139488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmartin-coforma
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
gmrabian
previously approved these changes
Oct 16, 2023
BearHanded
previously approved these changes
Oct 30, 2023
benmartin-coforma
dismissed stale reviews from BearHanded and gmrabian
via
52b84f9
|
I had to merge main & re-run |
|
Code Climate has analyzed commit 52b84f9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
gmrabian
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
styled-componentsfrom CARTS.styled-componentshas a reported "vulnerability": when installing certain versions, if it believes you are in Russia, it will print out a protest message regarding Ukraine. I don't personally see a problem with this, but our security scans do.As it happens, we don't actually use
styled-componentswithin CARTS; it is installed and then ignored. So I'm taking this as an opportunity to dismount the dependency upgrade treadmill, for this package at least.Related ticket(s)
CMDCT-2855
How to test
Important updates
N/A
Author checklist
[ ] I have added thorough tests, if necessary[ ] I have updated relevant documentation, if necessary