feat(lamda): add admin function for NOSOs #990
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
andieswift
temporarily deployed
to
admin-noso-app
GitHub Actions
Inactive
andieswift
temporarily deployed
to
admin-noso-kibana
GitHub Actions
Inactive
| // check if the package already exists; if it does shoudl not add new record | ||
| if (currentPackage) { | ||
| return response({ | ||
| statusCode: 404, |
There was a problem hiding this comment.
Doesn't 404 mean Not Found?
Comment on lines
+59
to
+63
| const parseEventBody = (body: unknown) => { | ||
| return submitNOSOAdminSchema.parse(typeof body === "string" ? JSON.parse(body) : body); | ||
| }; | ||
|
|
||
| const { packageId, action } = parseEventBody(event.body); |
There was a problem hiding this comment.
Would it make sense to just call submitNOSOAdminSchema.parse without abstracting it into a function?
|
Woops, didn't see the NOT READY badge. Ignore my comments 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
OY2-31182
💬 Description / Notes
🛠 Changes
📸 Screenshots / Demo