Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created helpers for getting domain and index for opensearch #989

Closed
wants to merge 3 commits into from

Conversation

thetif
Copy link
Collaborator

@thetif thetif commented Jan 8, 2025

💬 Description / Notes

Refactor to standard how we are getting the osDomain and index.

🛠 Changes

  • created a helper method for getting and normalizing the domain and index from the environment variables
  • updated code that got process.env.osDomain and/or process.env.indexNamespace to use the helper methods
  • updated the code and tests as necessary
  • updated appk tests to use mocked opensearch

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.64% 7139 / 8852
🔵 Statements 79.64% 7460 / 9367
🔵 Functions 71.89% 2077 / 2889
🔵 Branches 48.43% 1334 / 2754
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/lambda/deleteIndex.ts 100% 66.66% 100% 100%
lib/lambda/getAttachmentUrl.test.ts 98.27% 100% 94.11% 98.07% 14-16
lib/lambda/getAttachmentUrl.ts 83.78% 70% 100% 83.78% 86-110
lib/lambda/getCpocs.ts 100% 100% 100% 100%
lib/lambda/getSubTypes.ts 93.33% 75% 100% 93.33% 66-69
lib/lambda/getTypes.ts 93.33% 75% 100% 93.33% 58-61
lib/lambda/itemExists.test.ts 100% 100% 100% 100%
lib/lambda/search.test.ts 100% 100% 100% 100%
lib/lambda/search.ts 90% 75% 100% 89.65% 54-56
lib/libs/sink-lib.ts 100% 93.33% 100% 100%
lib/libs/utils.ts 100% 100% 100% 100%
lib/libs/api/package/appk.test.ts 100% 100% 100% 100%
lib/libs/api/package/appk.ts 100% 100% 100% 100%
lib/libs/api/package/changelog.ts 100% 100% 100% 100%
lib/libs/api/package/getPackage.ts 100% 100% 100% 100%
lib/libs/api/package/itemExists.ts 100% 75% 100% 100%
Generated in workflow #1414 for commit 5222e57 by the Vitest Coverage Report Action

@thetif thetif closed this Jan 8, 2025
@thetif thetif deleted the refactor-getDomainAndNamespace branch January 8, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants