pra disclosure #216
Merged
pra disclosure #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpaige
approved these changes
Nov 24, 2023
| <div className="flex justify-between"> | ||
| <Button variant="link">Save Draft</Button> | ||
| <div className="flex flex-row gap-4"> | ||
| <Button variant="outline">Back</Button> |
There was a problem hiding this comment.
this is great. we should prob talk to hcd about if they want "back" and if so what it should do
| @@ -0,0 +1,36 @@ | |||
| export const PraDisclosure = () => { | |||
| return ( | |||
| <div className="flex flex-col gap-2 my-6 text-sm text-slate-500"> | |||
There was a problem hiding this comment.
its kind of a footer, maybe we should make it one?
There was a problem hiding this comment.
If we change it to "footer", do you want to move the buttons into it as well?
Or keep those separate to leave possible space for other comps or alerts between the buttons and footer?
There was a problem hiding this comment.
I'm thinking just footer for the semantics and leave the buttons in its own element as it could change
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the PRA disclosure and button layout to the bottom of all generated forms. Needs to be confirmed with HDC for verbiage.
Linked Issues to Close
Ticket oy2-26378