-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go team... banner for no role case #206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13bfrancis
added a commit
that referenced
this pull request
Nov 21, 2023
commit 7bc0e0a Author: Kevin Haube <[email protected]> Date: Tue Nov 21 11:26:09 2023 -0500 Fix deploy commit 41dbeca Merge: 97fd56a 285b88d Author: Kevin Haube <[email protected]> Date: Tue Nov 21 11:19:21 2023 -0500 Merge master commit 97fd56a Author: Walesango2 <[email protected]> Date: Mon Nov 20 17:01:10 2023 -0500 go team... banner for no role case (#206) Co-authored-by: Mike Dial <[email protected]> commit df9b9dc Author: Kevin Haube <[email protected]> Date: Fri Nov 17 11:13:48 2023 -0500 Empty commit to re-deploy and fix back-end commit 049c567 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 14:17:11 2023 -0500 feat(withdraw package):implement withdraw package functionality commit ff20b77 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:38:47 2023 -0500 feat(withdraw package):implement withdraw package functionality commit d52ea5e Merge: 319869f b7d3c8f Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:24:38 2023 -0500 merging master commit 319869f Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:21:22 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 1dc6c8d Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:06:23 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 84efea3 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:00:01 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 191c612 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 12:38:55 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 595f570 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 15:49:54 2023 -0500 feat(withdraw package):implement withdraw package functionality commit ac42ea9 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 15:20:05 2023 -0500 feat(withdraw package):implement withdraw package functionality commit c61ebbd Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 14:58:28 2023 -0500 feat(merge master): merge master commit 53871cd Merge: 8703769 ee8d599 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 14:55:17 2023 -0500 feat(merge master): merge master commit 8703769 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 14:42:42 2023 -0500 feat(withdraw package):implement withdraw package functionality
You do not have access to view the entire application.{" "} | ||
<a | ||
rel="noreferrer" | ||
href="https://test.home.idm.cms.gov/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be an envar
</p> | ||
</div> | ||
)} | ||
{hasRole && <NoRole />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so hasrole present <NoRole/>
that doesnt make sense
13bfrancis
added a commit
that referenced
this pull request
Dec 8, 2023
…n enabled (#241) * add get package action code * setup for basic withdraw rai flow * fix error * Squashed commit of the following: commit 7bc0e0a Author: Kevin Haube <[email protected]> Date: Tue Nov 21 11:26:09 2023 -0500 Fix deploy commit 41dbeca Merge: 97fd56a 285b88d Author: Kevin Haube <[email protected]> Date: Tue Nov 21 11:19:21 2023 -0500 Merge master commit 97fd56a Author: Walesango2 <[email protected]> Date: Mon Nov 20 17:01:10 2023 -0500 go team... banner for no role case (#206) Co-authored-by: Mike Dial <[email protected]> commit df9b9dc Author: Kevin Haube <[email protected]> Date: Fri Nov 17 11:13:48 2023 -0500 Empty commit to re-deploy and fix back-end commit 049c567 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 14:17:11 2023 -0500 feat(withdraw package):implement withdraw package functionality commit ff20b77 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:38:47 2023 -0500 feat(withdraw package):implement withdraw package functionality commit d52ea5e Merge: 319869f b7d3c8f Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:24:38 2023 -0500 merging master commit 319869f Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:21:22 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 1dc6c8d Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:06:23 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 84efea3 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 13:00:01 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 191c612 Author: Adewale Sangobiyi <[email protected]> Date: Thu Nov 16 12:38:55 2023 -0500 feat(withdraw package):implement withdraw package functionality commit 595f570 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 15:49:54 2023 -0500 feat(withdraw package):implement withdraw package functionality commit ac42ea9 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 15:20:05 2023 -0500 feat(withdraw package):implement withdraw package functionality commit c61ebbd Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 14:58:28 2023 -0500 feat(merge master): merge master commit 53871cd Merge: 8703769 ee8d599 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 14:55:17 2023 -0500 feat(merge master): merge master commit 8703769 Author: Adewale Sangobiyi <[email protected]> Date: Wed Nov 15 14:42:42 2023 -0500 feat(withdraw package):implement withdraw package functionality * Revert "Squashed commit of the following:" This reverts commit e36ac8e. * Remove TODO - brian was right * set up modal flow * Function rai response withdraw * frontend work * More frontend * add character counter * make a few changes requested by Erika * Lay the groundwork for event flow * Add comments so I don't forget * Setup backend sink and event logic * Create an example of what will get sent back * Add file uploads to frontend form * Add API call * use new file upload service * change schema to transform data coming through the action type * fix type error * add a log for debugging the sink * log error message working theory is the key type is string * fix invalid type (needs to be a string) * add log to see what withdraw response body is * add attachment to map * fix submission to backend * add id to payload * remove withdraw rai meta data for now * add logging to the action lambda for errors * Add additional frontend logic * add payload to the sink * fix type error and add conditional checking for errors * fix type error? * fix type error * fix breadcrumb issue * fix title issue for withdraw rai * fix introductory text issue * fix attachment subtitle text issue * fix required fields issue * fix confirmation modal popup issue * fix per padma * set withdraw enabled to false upon withdrawal * Add spinner * use the attachments object like other pages * update success text * move back to PENDING instead of pending rai * Treat lifecycle of RAI as complete upon withdrawal, do some types, and show in UI * Remove now unused file * Remove unused imports and a comment * Change language * Fix additional information text * fix status text * Correct logic in RAI helper * Fix individual download * fix activerai removal * fix submission service upload component to work for multiple files of a given type * fix uplodas * Cleanup and comments * Account for a blank attachments array... and thereby hide the download all button and set info correctly * Fix dashboard response date population * Make generic catch all error message more correct * Run validation on first click.. number 9 * remove required tag cause its not required * Correct characters allowed description --------- Co-authored-by: Kevin Haube <[email protected]> Co-authored-by: Mike Dial <[email protected]>
Walesango2
added a commit
that referenced
this pull request
Dec 13, 2023
* feat(withdraw package):implement withdraw package functionality * feat(merge master): merge master * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package functionality * Empty commit to re-deploy and fix back-end * go team... banner for no role case (#206) Co-authored-by: Mike Dial <[email protected]> * Fix deploy * Fix File not defined error * Fix deploy * Re-export function * Return action in getPackageActions * feat(withdraw package):implement withdraw package functionality * feat(withdraw package):implement withdraw package action * feat(withdraw package):implement withdraw package action * feat(withdraw package):implement withdraw package action * Make changes to fix schema and form errors in ui * feat(withdraw package):testing * fix something * feat(withdraw package):implement withdraw package action * Extract reusable types * Revert "feat(withdraw package):implement withdraw package action" This reverts commit 93625aa. * remove linted file changes * Fix ID in form schema issue * Fix schema attachments issue * I guess this fix needs to be bundled...sadface * Fix transaction not begun error * Remove the enable/disable substatus for withdrawn packages * feat(withdraw package):implement withdraw package action * feat(withdraw package):implement withdraw package action * Collect submitter name and email * rename file * rename schema and type * feat(withdraw package):implement withdraw package action * Set up a transform for consistency sake. Since were not sending to opensearch, it doesnt do much * Update logic to only shown withdraw package if the package is in a pending status * feat(withdraw package):implement withdraw package action --------- Co-authored-by: Adewale Sangobiyi <[email protected]> Co-authored-by: Adewale Sangobiyi <[email protected]> Co-authored-by: Kevin Haube <[email protected]> Co-authored-by: Mike Dial <[email protected]> Co-authored-by: Kevin Haube <[email protected]> Co-authored-by: 13bfrancis <[email protected]> Co-authored-by: Adewale Sangobiyi <[email protected]> Co-authored-by: Adewale Sangobiyi <[email protected]> Co-authored-by: Adewale Sangobiyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Needed to update the banner failure message when users with n IDM role login to mako