fix(opensearch filters): Adjust opensearch filters for better UX #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdinh8124
requested review from
benjaminpaige,
daniel-belcher,
charmcitygavin and
pkim-gswell
benjaminpaige
approved these changes
Nov 16, 2023
Comment on lines
+52
to
+56
| test("title is rendered as an h2 and styled", () => { | ||
| renderOptionCard(false); | ||
| const header = screen.getByRole("heading", { level: 3 }); | ||
| const header = screen.getByRole("heading", { level: 2 }); | ||
| expect(header).toHaveTextContent("Test Card Title"); | ||
| expect(header).toHaveClass("text-lg text-sky-600 font-bold my-2"); | ||
| expect(header).toHaveClass("text-lg text-sky-700 font-bold my-2"); |
There was a problem hiding this comment.
whoa we have tests? 🤯
There was a problem hiding this comment.
Looks like Kevin wrote these!
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adjust mako open search filter issues found by Padma
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-25433
Assorted Notes/Considerations/Learning
This will be needed to be tested by Padma. Whether that is before or after a merge into Webforms branch is still up for discussion