Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FAQ): Update Implementation Guide PDFs to the most recent versions #1063

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

charmcitygavin
Copy link
Collaborator

🎫 Linked Ticket

OY2-31990

💬 Description / Notes

The OneMAC FAQ had outdated implementation guide PDFs. This ticket updates them with the latest versions provided in OY2-31756.

The original ticket lacked some information we tracked down:

  • Some PDFs had "Final" while others had "Draft" in their filenames, causing confusion. We had to pause work to get clarity on these files. It turned out that they are all final and approved files, regardless of whether they were labeled "Final" or Draft.
  • We were also asked to remove the "Final" or "Draft" parts of the filenames, though this was not included in the original ticket.
  • There was a missing PDF for the CS 13 implementation guide.
  • CS 14 needed to be removed from both the templates and implementation guide sections.

Additionally, ABP 2c was missing from the templates and IG sections, so I added those missing files.

🛠 Changes

The old PDFs were removed, new PDFs added, and the filenames were changed based on feedback.

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.63% 3859 / 4670
🔵 Statements 82.14% 4209 / 5124
🔵 Functions 72.66% 1122 / 1544
🔵 Branches 65.94% 1816 / 2754
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/faq/content/abpGuides.ts 100% 100% 100% 100%
react-app/src/features/faq/content/abpTemplate.ts 100% 100% 100% 100%
react-app/src/features/faq/content/chpTemplates.ts 100% 100% 100% 100%
react-app/src/features/faq/content/mpcTemplates.ts 100% 100% 100% 100%
Generated in workflow #1657 for commit 422b19f by the Vitest Coverage Report Action

@charmcitygavin charmcitygavin marked this pull request as ready for review January 24, 2025 17:10
Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the code 😂?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants