Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test) dependency wrapper test #1061

Merged
merged 2 commits into from
Jan 24, 2025
Merged

feat(test) dependency wrapper test #1061

merged 2 commits into from
Jan 24, 2025

Conversation

thwalker6
Copy link
Collaborator

🎫 Linked Ticket

[Ticket to close](https://jiraent.cms.gov/browse/OY2-32532)

💬 Description / Notes

Additional unit test for the dependency wrapper. One is for the functions and paths, one is for the rendering.

🛠 Changes

Changed a function to become an export for testing purposes.

📸 Screenshots / Demo

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.01% 3877 / 4670
🔵 Statements 82.53% 4229 / 5124
🔵 Functions 72.79% 1124 / 1544
🔵 Branches 66.99% 1845 / 2754
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/components/RHF/dependencyWrapper.tsx 94.64% 92.64% 90.9% 96.07% 7, 100
Generated in workflow #1661 for commit c22d5b2 by the Vitest Coverage Report Action

@thwalker6 thwalker6 temporarily deployed to dependency-wrapper-test January 24, 2025 15:56 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dependency-wrapper-test-app January 24, 2025 15:56 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dependency-wrapper-test-kibana January 24, 2025 15:56 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dependency-wrapper-test January 24, 2025 15:56 — with GitHub Actions Inactive
@thwalker6 thwalker6 temporarily deployed to dependency-wrapper-test January 24, 2025 15:56 — with GitHub Actions Inactive
Copy link
Collaborator

@andieswift andieswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test LGTM, nice work getting that coverage up!!
And also I feel good about the decencies now :)

@thwalker6 thwalker6 merged commit 180107c into main Jan 24, 2025
14 checks passed
@thwalker6 thwalker6 deleted the dependency-wrapper-test branch January 24, 2025 17:58
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.114 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants