fix(te): Refactor TEs to use authority and lots of cleanup #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
asharonbaltazar
approved these changes
Jan 23, 2025
lib/libs/utils.ts
Outdated
| export function getNamespace<T extends BaseIndex>(baseIndex?: T): Index; | ||
| export function getNamespace(baseIndex?: BaseIndex) { | ||
| const indexNamespace = process.env.indexNamespace ?? ""; | ||
| export function getOsNamespace<T extends BaseIndex>(baseIndex: T): Index; |
There was a problem hiding this comment.
If the overloaded function is no longer needed, can we remove it? Also, perhaps we can adjust the return value to return what you typed in itemExists, line 8
There was a problem hiding this comment.
If the overloaded function is no longer needed, can we remove it? Also, perhaps we can adjust the return value to return what you typed in
itemExists, line 8
good call, refactored.
i hate waited resources. nothing unused, nothing undefined. as it should be in code and life
benjaminpaige
changed the title
benjaminpaige
temporarily deployed
to
te-bnc-es
GitHub Actions
Inactive
benjaminpaige
temporarily deployed
to
te-bnc-es
GitHub Actions
Inactive
benjaminpaige
temporarily deployed
to
te-bnc-es
GitHub Actions
Inactive
benjaminpaige
temporarily deployed
to
te-bnc-es
GitHub Actions
Inactive
benjaminpaige
temporarily deployed
to
te-bnc-es
GitHub Actions
Inactive
|
🎉 This PR is included in version 1.5.0-val.113 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding or refactoring TE's to match the appropriate authority template types.
Also did some cleaning up of index namespace functions and requiring certain environment variables.
I did a little refactoring of the Get Template functionality to make it more readable.
🎫 Linked Ticket
https://jiraent.cms.gov/browse/OY2-30069
📸 Screenshots / Demo