fix(ui): hide errors for individual files when uploading subsequent docs #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asharonbaltazar
changed the title
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
asharonbaltazar
requested review from
tbolt,
thwalker6,
13bfrancis and
andieswift
asharonbaltazar
temporarily deployed
to
fix-sub-attachments
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
fix-sub-attachments
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
fix-sub-attachments
GitHub Actions
Inactive
andieswift
approved these changes
Jan 23, 2025
tbolt
approved these changes
Jan 23, 2025
|
🎉 This PR is included in version 1.5.0-val.114 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
RanyeM
pushed a commit
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
OY2-32247
💬 Description / Notes
We needed to overwrite the previous schema with an optional value to hide the schema's attachments property's respective errors. This also meant the
filesproperty needed an update allowing us to access those properties in a type-safe way.🛠 Changes
📸 Screenshots / Demo
Screen.Recording.2025-01-22.at.8.04.22.PM.mov