Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch-role): allow log group creation for firehose role #1054

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

Seun0925
Copy link
Collaborator

🎫 Linked Ticket

Ticket to close

💬 Description / Notes

The log says there was an explicit deny rule for log creation.
I created an explicit allow on the cloudwatch resource policy

🛠 Changes

📸 Screenshots / Demo

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.14% 3747 / 4675
🔵 Statements 79.45% 4075 / 5129
🔵 Functions 70.25% 1084 / 1543
🔵 Branches 61.62% 1702 / 2762
File CoverageNo changed files found.
Generated in workflow #1635 for commit d7dd872 by the Vitest Coverage Report Action

@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 22, 2025 22:36 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 22, 2025 22:36 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group-kibana January 22, 2025 22:36 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group-app January 22, 2025 22:36 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 22, 2025 22:36 — with GitHub Actions Inactive
Copy link
Collaborator

@13bfrancis 13bfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Be sure to squash and merge below when merging

@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 23, 2025 17:24 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 23, 2025 17:24 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 23, 2025 17:26 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 23, 2025 17:26 — with GitHub Actions Inactive
@Seun0925 Seun0925 temporarily deployed to fix-cloudwatch-log-group January 23, 2025 17:26 — with GitHub Actions Inactive
@Seun0925 Seun0925 merged commit 52d31b6 into main Jan 23, 2025
15 checks passed
@Seun0925 Seun0925 deleted the fix-cloudwatch-log-group branch January 23, 2025 17:31
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.113 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants