-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pkg-details): Redirect back to dashboard when new amendment or TE #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
asharonbaltazar
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 16, 2025 18:10 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 16, 2025 18:10 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 16, 2025 18:15 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 16, 2025 18:15 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect-app
January 16, 2025 18:15 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect-kibana
January 16, 2025 18:15 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 16, 2025 18:15 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 27, 2025 18:04 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 27, 2025 18:04 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 27, 2025 18:09 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 27, 2025 18:09 — with
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
details-actions-redirect
January 27, 2025 18:09 — with
GitHub Actions
Inactive
🎉 This PR is included in version 1.5.0-val.115 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
OY2-31120
💬 Description / Notes
When a new amendment or temporary extension is submitted from a package details page, the user is redirected back to the package details page. For better user experience, they should be redirected to the dashboard.
🛠 Changes
The URL form origin for adding an amendment or temporary extension has been changed to "waivers" so users are redirected to the waivers tab on the dashboard to see the newly created amendment/TE after submitting.
📸 Screenshots / Demo
Screen.Recording.2025-01-13.at.2.02.16.PM.mov