Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg-details): Redirect back to dashboard when new amendment or TE #1017

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

tiffanyvu
Copy link
Collaborator

🎫 Linked Ticket

OY2-31120

💬 Description / Notes

When a new amendment or temporary extension is submitted from a package details page, the user is redirected back to the package details page. For better user experience, they should be redirected to the dashboard.

🛠 Changes

The URL form origin for adding an amendment or temporary extension has been changed to "waivers" so users are redirected to the waivers tab on the dashboard to see the newly created amendment/TE after submitting.

📸 Screenshots / Demo

Screen.Recording.2025-01-13.at.2.02.16.PM.mov

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 85.63% 4019 / 4693
🔵 Statements 85.06% 4380 / 5149
🔵 Functions 76.7% 1189 / 1550
🔵 Branches 69.61% 1941 / 2788
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/package/package-actions/index.tsx 20% 0% 0% 20% 9-27
Generated in workflow #1692 for commit 0dc0fa5 by the Vitest Coverage Report Action

Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 16, 2025 18:10 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 16, 2025 18:10 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 16, 2025 18:15 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 16, 2025 18:15 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect-app January 16, 2025 18:15 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect-kibana January 16, 2025 18:15 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 16, 2025 18:15 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 27, 2025 18:04 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 27, 2025 18:04 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 27, 2025 18:09 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 27, 2025 18:09 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu temporarily deployed to details-actions-redirect January 27, 2025 18:09 — with GitHub Actions Inactive
@tiffanyvu tiffanyvu merged commit 89430c4 into main Jan 27, 2025
15 checks passed
@tiffanyvu tiffanyvu deleted the details-actions-redirect branch January 27, 2025 18:24
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.115 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

RanyeM pushed a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants