Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ReadMe #67

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Updated ReadMe #67

merged 4 commits into from
Dec 19, 2024

Conversation

maira-samtek
Copy link
Contributor

No description provided.

README.md Outdated

You can utilize the outputs to extend the security hub functionalities. This is especially useful for real-time updates on your security findings and issue tracking.

For example, You can refer to this [Slack Alert Example](https://github.com/Enterprise-CMCS/mac-fc-embedded/blob/zarate-sechub-v2-enterprise/.github/workflows/jira-sync-v2-test.yaml) for a working implementation of Slack notifications in your Security Hub integration workflow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend either moving the example code to the v2 (or main) branch or adding it to this readme file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonassrobi updated the link to refer test.yaml in v2 branch with the slack alert example

Copy link
Contributor

@yonassrobi yonassrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment that can be easily addressed.

@maira-samtek maira-samtek merged commit 25834ea into v2 Dec 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants