Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Option For Low Load: Delay Update Names #1395

Merged
merged 8 commits into from
Jan 26, 2025
Merged

New Option For Low Load: Delay Update Names #1395

merged 8 commits into from
Jan 26, 2025
+178 −149

Conversation

Tommy-XL
Copy link
Collaborator

@Tommy-XL Tommy-XL commented Jan 24, 2025 •
edited
Loading

New low load option

The main purpose of this setting is to update player names on the host only when NotifyRoles was runned for vanilla players, so it is not necessary for it to update the nickname every second

Works only during the game

For modded clients that are not hosts, this is not necessary, because the main load goes only to the host

@Tommy-XL Tommy-XL added the New Setting Adding a new setting label Jan 24, 2025
@Tommy-XL
Copy link
Collaborator Author

Haven't tested it yet and set the setting to off by default

@Tommy-XL
Copy link
Collaborator Author

Okay, after testing it works as it should
The only question is, should this setting be enabled by default?

@Tommy-XL Tommy-XL marked this pull request as ready for review January 25, 2025 06:19
@NikoCat233 NikoCat233 merged commit 1d98959 into dev_2.2.0 Jan 26, 2025
1 check passed
@NikoCat233 NikoCat233 deleted the LowLoadDelayUpdateNames branch January 26, 2025 00:58
NikoCat233 added a commit that referenced this pull request Jan 26, 2025
@NikoCat233
Squashed commit of the following:
3af0974 
commit 4b6e0c9
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 11:30:44 2025 +0800

    Send failed error on failed murder attempts

commit 7fc51e1
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 11:13:44 2025 +0800

    Add option NonCrewRandomCommonTasks

commit a9a9ad3
Merge: 4e752f6 1d98959
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 09:01:56 2025 +0800

    Merge branch 'dev_2.2.0' of https://github.com/EnhancedNetwork/TownofHost-Enhanced into dev_2.2.0

commit 4e752f6
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 09:01:45 2025 +0800

    Alpha 15 testing

commit 1d98959
Merge: 713f669 3292dbf
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 08:58:23 2025 +0800

    Merge pull request #1395 from EnhancedNetwork/LowLoadDelayUpdateNames

    New Option For Low Load: Delay Update Names

commit 713f669
Merge: fa36ded 08488b8
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 08:57:00 2025 +0800

    Merge branch 'l10n_main' into dev_2.2.0

commit fa36ded
Merge: e29b506 56f932a
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 08:46:37 2025 +0800

    Merge branch 'dev_2.2.0' of https://github.com/EnhancedNetwork/TownofHost-Enhanced into dev_2.2.0

commit e29b506
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 08:46:15 2025 +0800

    Attempt to fix names not loading on meeting

commit 56f932a
Merge: d9100f8 f80f1e3
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 08:17:36 2025 +0800

    Merge pull request #1392 from Bri1101/psychic-fix

    Fix Madmate Psychic not seeing all Neutrals displayed in red names

commit d9100f8
Merge: 539f4c5 2b75787
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 08:16:24 2025 +0800

    Merge pull request #1394 from impostor4291/guesser

    Guesser

commit 539f4c5
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 08:13:29 2025 +0800

    Fix RemoveIncompatibleAddOns ducking recruiting addons

commit 796927d
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 07:41:50 2025 +0800

    Fix GM not seeing addons

commit 85d90be
Merge: 4ba8d1b 0d62a3c
Author: Niko233 <[email protected]>
Date:   Sun Jan 26 07:33:58 2025 +0800

    Merge pull request #1396 from EnhancedNetwork/FixAmnesiacDontClearArrowsAfterRememberingRole

    Fix bug when Amnesiac don't clear arrows after remembering role

commit 08488b8
Author: Moe <[email protected]>
Date:   Sat Jan 25 17:56:39 2025 -0500

    New translations en_us.json (Italian)

commit 3ab2589
Author: Moe <[email protected]>
Date:   Sat Jan 25 16:10:39 2025 -0500

    New translations en_us.json (Italian)

commit f91f5f2
Author: Moe <[email protected]>
Date:   Sat Jan 25 15:11:43 2025 -0500

    New translations en_us.json (Italian)

commit 8e3cf9e
Author: Moe <[email protected]>
Date:   Sat Jan 25 08:30:41 2025 -0500

    New translations en_us.json (Italian)

commit 7f9202e
Author: Moe <[email protected]>
Date:   Sat Jan 25 06:21:20 2025 -0500

    New translations en_us.json (Italian)

commit 8bb46e9
Author: Moe <[email protected]>
Date:   Sat Jan 25 05:25:26 2025 -0500

    New translations en_us.json (Italian)

commit fa25d02
Author: Moe <[email protected]>
Date:   Sat Jan 25 04:25:22 2025 -0500

    New translations en_us.json (Italian)

commit 3292dbf
Author: Tommy XL <[email protected]>
Date:   Sat Jan 25 14:17:18 2025 +0800

    Set enabled by default

commit 0d62a3c
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 23:38:18 2025 +0800

    Fix bug when Amnesiac don't clear arrows after remembering role

commit 5bd9228
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 23:22:11 2025 +0800

    Change

commit 66909ac
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 23:14:06 2025 +0800

    Fix arrows update again

commit 2b75787
Author: ImpyIsLazy <[email protected]>
Date:   Fri Jan 24 23:13:50 2025 +0800

    Update GuessManager.cs

commit 680ff37
Author: ImpyIsLazy <[email protected]>
Date:   Fri Jan 24 23:11:08 2025 +0800

    Update EvilGuesser.cs

commit cb66786
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 23:08:21 2025 +0800

    Fix arrows update

commit c9bfb94
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 22:58:54 2025 +0800

    Fix bugs

commit 4ba8d1b
Author: Niko233 <[email protected]>
Date:   Fri Jan 24 22:53:15 2025 +0800

    Fix player seeing vanilla names after unshapshift serialize

commit aab5260
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 22:28:34 2025 +0800

    Fix option parent

commit d608db7
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 22:26:43 2025 +0800

    Update after intro

commit 1ad8acd
Author: Tommy XL <[email protected]>
Date:   Fri Jan 24 22:18:31 2025 +0800

    New Option For Low Load: Delay Update Names

commit 1fbaa71
Author: Niko233 <[email protected]>
Date:   Fri Jan 24 22:12:56 2025 +0800

    Add a delay in start meeting to allow other tasks to finish

commit 7b7b827
Author: Niko233 <[email protected]>
Date:   Fri Jan 24 21:38:42 2025 +0800

    Update UnshapeShifter Method

commit 89e655b
Author: Niko233 <[email protected]>
Date:   Fri Jan 24 20:41:27 2025 +0800

    Attempt to fix shapeshifter player see host skin in game

commit 2327425
Author: ImpyIsLazy <[email protected]>
Date:   Fri Jan 24 11:08:03 2025 +0800

    Update GuessManager.cs

commit f1508c1
Author: ImpyIsLazy <[email protected]>
Date:   Fri Jan 24 11:03:09 2025 +0800

    Update EvilGuesser.cs

commit 85b0acc
Author: ImpyIsLazy <[email protected]>
Date:   Fri Jan 24 11:02:24 2025 +0800

    Update NiceGuesser.cs

commit f80f1e3
Author: Bri-11 <[email protected]>
Date:   Thu Jan 23 11:36:44 2025 -0500

    Fix Madmate Psychic not seeing all Neutrals in red names

commit 4340081
Merge: e83353e 19e7d44
Author: Bri1101 <[email protected]>
Date:   Thu Jan 23 11:00:37 2025 -0500

    Merge pull request #18 from EnhancedNetwork/dev_2.2.0

    Dev 2.2.0

commit 19e7d44
Merge: 89cee97 bb50a43
Author: Niko233 <[email protected]>
Date:   Thu Jan 23 21:58:30 2025 +0800

    Merge pull request #1390 from EnhancedNetwork/ForceUpdateNotifyRoles

    Force update NotifyRoles() for all after murder (for roles using arrows)

commit bb50a43
Author: Tommy XL <[email protected]>
Date:   Thu Jan 23 21:23:57 2025 +0800

    Force update NotifyRoles() for all after murder (for roles using arrows)

commit dd93654
Merge: 3fc73a3 89cee97
Author: ImpyIsLazy <[email protected]>
Date:   Thu Jan 23 21:09:27 2025 +0800

    Merge pull request #67 from EnhancedNetwork/dev_2.2.0

    Dev 2.2.0

commit 033b1a0
Author: Moe <[email protected]>
Date:   Wed Jan 22 17:21:05 2025 -0500

    New translations modnews-en_us.json (Chinese Traditional)

commit a3dba70
Author: Moe <[email protected]>
Date:   Wed Jan 22 15:47:49 2025 -0500

    New translations modnews-en_us.json (Chinese Traditional)

commit 3e3ec31
Author: Moe <[email protected]>
Date:   Wed Jan 22 11:33:25 2025 -0500

    New translations en_us.json (Chinese Traditional)

commit 2adbdf7
Author: Moe <[email protected]>
Date:   Wed Jan 22 11:33:23 2025 -0500

    New translations en_us.json (Chinese Simplified)

commit e83353e
Merge: 1b96fd4 f7edda0
Author: Bri1101 <[email protected]>
Date:   Wed Jan 22 10:10:01 2025 -0500

    Merge pull request #17 from EnhancedNetwork/dev_2.2.0

    Dev 2.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikoCat233 NikoCat233 NikoCat233 approved these changes

Assignees
No one assigned
Labels
New Setting Adding a new setting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tommy-XL @NikoCat233