Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Overhaul Sorting #1373

Merged
merged 7 commits into from
Jan 19, 2025
Merged

Tag Overhaul Sorting #1373

merged 7 commits into from
Jan 19, 2025

Conversation

NotPyro404
Copy link
Collaborator

@NotPyro404 NotPyro404 commented Jan 17, 2025

Margs Tag Overhaul is epic but can get messy, so this PR should make it so friendCode#1234.txt file can be read in a folder (Example like Friends folder, Staff folder, ABCDEF folder, etc), as long as its under the Tags directory. The only folders it shouldn't read are MOD_TAGS, VIP_TAGS, & SPONSOR_TAGS.

@MargaretTheFool
Copy link
Contributor

build failed :ten_uhh:
also its permissions 0-5 not 1-5

@NotPyro404
Copy link
Collaborator Author

build failed :ten_uhh: also its permissions 0-5 not 1-5

oh also idk how to build anything im just an idiot who likes doing things sometimes and then isnt surprised they fail

@NotPyro404
Copy link
Collaborator Author

I did it I'm a genius

@Pietrodjaowjao
Copy link
Contributor

Why is this so hardcoded

@MargaretTheFool
Copy link
Contributor

that's what I was trying to prevent

@NotPyro404
Copy link
Collaborator Author

Why is this so hardcoded

how so? is it not the same system but sorted into specific folders?

the current ones good but can get flooded

@NotPyro404
Copy link
Collaborator Author

I am failing to see how this is hardcoded if you could just move the friendcode.txt to a seperate folder to change their permission level, the variables/access lines inside the txt file should stay the same unless i messed that up

@NotPyro404 NotPyro404 changed the title Edit Tags system sorting + how PermissionLevel is determined [Review] Edit Tags system sorting [Review] Jan 18, 2025
@NotPyro404 NotPyro404 marked this pull request as ready for review January 18, 2025 02:04
@NotPyro404 NotPyro404 changed the title Edit Tags system sorting [Review] Edit Tags system sorting Jan 18, 2025
@NotPyro404 NotPyro404 changed the title Edit Tags system sorting Tag Overhaul Sorting Jan 18, 2025
@NotPyro404
Copy link
Collaborator Author

Okay so now it should use the new system (margs new one, not the one utilizing folders for perms), and read the friendcode#1234.txt as long as its under the Tags directory, even if it's in a folder (Example like Friends folder, Staff folder, ABCDEF folder, etc). The only folders it shouldn't read are MOD_TAGS, VIP_TAGS, & SPONSOR_TAGS.

@NikoCat233 NikoCat233 merged commit 8fe3923 into EnhancedNetwork:dev_2.2.0 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants