Specific undefined type exceptions + Support FQCN types in MethodScript code #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadyCailin
approved these changes
Mar 28, 2024
Pieter12345
force-pushed
the
specific-undefined-type-exceptions
branch
from
36fc463 to
4bf2efc
Compare
- Wrap bare strings in `__type_ref__()` if they are used as a type in syntax. - Handle `__type_ref__()` unknown types in StaticAnalysis typechecking. - Handle `__type_ref__()` unknown types in runtime when StaticAnalysis is disabled. Avoids getting a set of cryptic exceptions when using an non-existent types.
Pieter12345
force-pushed
the
specific-undefined-type-exceptions
branch
from
4bf2efc to
90e4c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific undefined type exceptions
__type_ref__()if they are used as a type in syntax.__type_ref__()unknown types in StaticAnalysis typechecking.__type_ref__()unknown types in compile time when StaticAnalysis is disabled (this is possible until custom user types are added, at which point StaticAnalysis would be necessary to determine whether these types exist or not).Avoids getting a set of cryptic exceptions when using an non-existent types.
Support FQCN types in MethodScript code
Support FQCN in
ms.lang.int @a = 1;,try {} catch (ms.lang.Exception @ex) {}andproc _a(ms.lang.int @a) {}syntax.Note that
assign(ms.lang.int, @a, 1)is not supported due toassign.postParseRewrite()running after bare string warning/error generation.