Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS3.5 H3.2 compliant #445

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 31 additions & 1 deletion encoding/src/text.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
//!
//! [`SpecificCharacterSet`]: ./enum.SpecificCharacterSet.html

use encoding::all::{GB18030, ISO_8859_1, ISO_8859_2, ISO_8859_3, ISO_8859_4, ISO_8859_5, UTF_8};
use encoding::all::{
GB18030, ISO_2022_JP, ISO_8859_1, ISO_8859_2, ISO_8859_3, ISO_8859_4, ISO_8859_5, UTF_8,
WINDOWS_31J,
};
use encoding::{DecoderTrap, EncoderTrap, Encoding, RawDecoder, StringWriter};
use snafu::{Backtrace, Snafu};
use std::borrow::Cow;
Expand Down Expand Up @@ -141,6 +144,10 @@ pub enum SpecificCharacterSet {
IsoIr192,
/// **GB18030**: The Simplified Chinese character set.
Gb18030,
/// **IsoIr13**: The Simplified Japanese single byte character set.
IsoIr13,
/// **IsoIr87**: The Simplified Japanese multi byte character set.
IsoIr87,
// Support for more text encodings is tracked in issue #40.
}

Expand Down Expand Up @@ -168,6 +175,8 @@ impl SpecificCharacterSet {
"ISO_IR_144" | "ISO_IR 144" | "ISO 2022 IR 144" => Some(IsoIr144),
"ISO_IR_192" | "ISO_IR 192" => Some(IsoIr192),
"GB18030" => Some(Gb18030),
"ISO_IR_13" | "ISO 2022 IR 13" => Some(IsoIr13),
"ISO_IR_87" | "ISO 2022 IR 87" => Some(IsoIr87),
_ => None,
}
}
Expand All @@ -184,6 +193,8 @@ impl TextCodec for SpecificCharacterSet {
SpecificCharacterSet::IsoIr144 => "ISO_IR 144",
SpecificCharacterSet::IsoIr192 => "ISO_IR 192",
SpecificCharacterSet::Gb18030 => "GB18030",
SpecificCharacterSet::IsoIr13 => "ISO_IR 13",
SpecificCharacterSet::IsoIr87 => "ISO_IR 87",
}
}

Expand All @@ -197,6 +208,8 @@ impl TextCodec for SpecificCharacterSet {
SpecificCharacterSet::IsoIr144 => IsoIr144CharacterSetCodec.decode(text),
SpecificCharacterSet::IsoIr192 => Utf8CharacterSetCodec.decode(text),
SpecificCharacterSet::Gb18030 => Gb18030CharacterSetCodec.decode(text),
SpecificCharacterSet::IsoIr13 => IsoIr13CharacterSetCodec.decode(text),
SpecificCharacterSet::IsoIr87 => IsoIr87CharacterSetCodec.decode(text),
}
}

Expand All @@ -210,6 +223,8 @@ impl TextCodec for SpecificCharacterSet {
SpecificCharacterSet::IsoIr144 => IsoIr144CharacterSetCodec.encode(text),
SpecificCharacterSet::IsoIr192 => Utf8CharacterSetCodec.encode(text),
SpecificCharacterSet::Gb18030 => Gb18030CharacterSetCodec.encode(text),
SpecificCharacterSet::IsoIr13 => IsoIr13CharacterSetCodec.encode(text),
SpecificCharacterSet::IsoIr87 => IsoIr87CharacterSetCodec.encode(text),
}
}
}
Expand Down Expand Up @@ -288,6 +303,8 @@ decl_character_set!(IsoIr110CharacterSetCodec, "ISO_IR 110", ISO_8859_4);
decl_character_set!(IsoIr144CharacterSetCodec, "ISO_IR 144", ISO_8859_5);
decl_character_set!(Utf8CharacterSetCodec, "ISO_IR 192", UTF_8);
decl_character_set!(Gb18030CharacterSetCodec, "GB18030", GB18030);
decl_character_set!(IsoIr13CharacterSetCodec, "ISO_IR_13", WINDOWS_31J);
decl_character_set!(IsoIr87CharacterSetCodec, "ISO_IR_87", ISO_2022_JP);

/// The result of a text validation procedure (please see [`validate_iso_8859`]).
#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
Expand Down Expand Up @@ -408,4 +425,17 @@ mod tests {
b"\xb8\xd2\xd0\xdd\xda\xde\xd2^\xb0\xdd\xd4\xe0\xd5\xd9",
);
}

#[test]
fn iso_ir_13_baseline() {
let codec = SpecificCharacterSet::IsoIr13;
test_codec(codec, "ヤマダ^タロウ", b"\xd4\xcf\xc0\xde^\xc0\xdb\xb3");
}

#[test]
fn iso_ir_87_baseline() {
let codec = SpecificCharacterSet::IsoIr87;
test_codec(codec, "山田^太郎", b"\x1b$B;3ED\x1b(B^\x1b$BB@O:");
test_codec(codec, "やまだ^たろう", b"\x1b$B$d$^$@\x1b(B^\x1b$B$?$m$&");
}
}
1 change: 1 addition & 0 deletions parser/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ dicom-dictionary-std = { path = "../dictionary-std/", version = "0.6.1" }
smallvec = "1.6.1"
snafu = "0.8"
tracing = "0.1.34"
encoding_rs = "0.8.33"
Loading
Loading