Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: match updated designs for button #1560

Open
wants to merge 2 commits into
base: esds-3.0-vue3-primevue
Choose a base branch
from

Conversation

ericdouglaspratt
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt commented Nov 19, 2024

πŸ”— Linked issue

  • n/a

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Matches the updated Figma designs for buttons, especially the 1px border rather than 2px
  • All focus states will only appear on :focus-visible instead of :focus, meaning you won't see them showing up unnecessarily on mouse/tap interaction, but you will see them on keyboard tabbing, which is exactly when Chrome shows its default focus outlines
  • Greatly simplified the Button docs page with more straightforward examples to copy from
  • Gave non-inline link buttons a darker active state and the press-down animation to match their siblings
  • Removed the dark-bg button variant's glow shadow

πŸ₯Ό Testing

  • Tested locally

🧐 Feedback Requested / Focus Areas

  • Overall

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, no obvious issues with the code! I do have one concern with the changes in focus state- the dark background examples are now harder to see when navigating by keyboard, as compared to the current implementation. That's because the light blue outline is no longer present on focus. Were these changes part of the scope of the design request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants