Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed + Comment Polish #99

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Feed + Comment Polish #99

merged 9 commits into from
Aug 6, 2024

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Aug 2, 2024

This diff is a quick design pass to solidify what feed items, comments, and all the general components look like. This also addresses loading states and makes sure everything looks good as a v1.

Copy link

emerge-tools bot commented Aug 2, 2024

📸 Snapshot Test

29 modified, 4 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0 (1) 0 0 29 4 0 ✅ Approved

🛸 Powered by Emerge Tools

@Rahkeen Rahkeen force-pushed the rikin.feed-comment-polish branch from a95906b to df77730 Compare August 5, 2024 19:46
@Rahkeen Rahkeen force-pushed the rikin.feed-comment-polish branch from df77730 to 8dfba30 Compare August 6, 2024 21:25
@Rahkeen Rahkeen merged commit e9ed503 into main Aug 6, 2024
4 of 5 checks passed
@Rahkeen Rahkeen deleted the rikin.feed-comment-polish branch August 6, 2024 21:42
Rahkeen added a commit that referenced this pull request Aug 8, 2024
This diff is a quick design pass to solidify what feed items, comments,
and all the general components look like. This also addresses loading
states and makes sure everything looks good as a v1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants