Bookmarking Stories to Read Later #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 builds increased size
Hacker News 1.0 (1)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 androidx.room.RoomOpenHelper | ⬆️ 4.3 kB | ⬆️ 1.9 kB |
| androidx.tracing.Trace | ⬇️ -3.8 kB | ⬇️ -1.7 kB |
| 📝 kotlin.collections.builders.MapBuilder | ⬆️ 3.6 kB | ⬆️ 1.7 kB |
| kotlin.text.CharsKt | ⬆️ 3.4 kB | ⬆️ 1.5 kB |
| 📝 androidx.compose.material3.NavigationBarKt | ⬆️ 3.4 kB | ⬆️ 1.5 kB |
View Treemap
Hacker News 1.0 (1)
com.emergetools.hackernews.debug
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 504.4 kB (1.84%)
Total download size change: ⬆️ 191.3 kB (2.04%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 androidx.room.InvalidationTracker | ⬆️ 5.8 kB | ⬆️ 2.0 kB |
| 📝 androidx.room.RoomDatabase | ⬆️ 5.2 kB | ⬆️ 1.8 kB |
| 📝 androidx.room.util.TableInfoKt | ⬆️ 4.8 kB | ⬆️ 1.7 kB |
| 📝 androidx.room.RoomDatabase$Builder | ⬆️ 4.3 kB | ⬆️ 1.5 kB |
| 📝 androidx.room.QueryInterceptorDatabase | ⬆️ 4.1 kB | ⬆️ 1.4 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test3 modified, 2 added, 8 unchanged
🛸 Powered by Emerge Tools |
⏱ Performance AnalysisHacker News
🛸 Powered by Emerge Tools |
rbro112
reviewed
Jul 15, 2024
android/app/build.gradle.kts
Outdated
| @@ -27,6 +28,11 @@ android { | |||
| debug { | |||
| isDebuggable = true | |||
| applicationIdSuffix = ".debug" | |||
| } | |||
| create("fast") { | |||
rbro112
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this diff, I'm taking a pass at bookmarking functionality. This required adding some infrastructure, namely Room as our local database.
The action is wired up to a long press for now, which will allow you to bookmark / unbookmark a story. There is also a separate screen and bottom nav item for bookmarks so we can easily navigate there.