Feed Loading Strategy #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahkeen
force-pushed
the
lazy-loading-feed-strategy
branch
from
c9624b2 to
904966b
Compare
This is an idea I have to load the feed lazily given the current infrastructure. When we request a feed, we have a list of ID's, so we can populate our LazyList with a bunch of Loading State items. Whenever I Loading State item comes into the Composition, it launches a `SideEffect` which will call up to the ViewModel to fetch that item.
After second thought, I think the better approach is paging. And since we don't have actual paging via the API, we can simulate it. Just create a simple repository layer which wraps the actual base client, and adds the ability to request pages. The requests are still sequential, but that can be updated later to be a series of async requests. Some rationale here is that although with first approach we can keep scrolling, a fling will cause a bunch of network requests which could end up being quite costly. The only thing that is a bit funky is the LazyList detecting how close we are to the end logic. I think this solution works but it probably needs more testing.
Rahkeen
force-pushed
the
lazy-loading-feed-strategy
branch
from
904966b to
0b4f226
Compare
rbro112
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After second thought, I think the better approach is paging. And since we don't have actual paging via the API, we can simulate it.
Created a simple repository layer which wraps the actual base client, and adds the ability to request pages.
The requests are still sequential, but that can be updated later to be a series of async requests.
Some rationale here is that although with first approach we can keep scrolling, a fling will cause a bunch of network requests which could end up being quite costly.
The only thing that is a bit funky is the LazyList detecting how close we are to the end logic. I think this solution works but it probably needs more testing.