Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping the Android Repo #58

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Swapping the Android Repo #58

merged 3 commits into from
Jul 9, 2024

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Jul 8, 2024

Merging in the new Hacker News android app!

Gracefully merged gradle configs and copied over the previous proguard rules.

Rahkeen and others added 2 commits July 8, 2024 15:09
Renamed package structure to com.emergetools.hackernews

Restored previous proguard, and merged in previous app/build.gradle
@Rahkeen Rahkeen requested a review from rbro112 July 8, 2024 22:44
Copy link

emerge-tools bot commented Jul 8, 2024

1 build decreased size

Name Version Download Change Install Change Approval
Hacker News
com.emergetools.hackernews.debug
1.0 (1) 9.3 MB ⬇️ 8.5 MB (-47.86%) 27.1 MB ⬇️ 33.1 MB (-54.96%) N/A

Hacker News 1.0 (1)
com.emergetools.hackernews.debug

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 33.1 MB (-54.96%)
Total download size change: ⬇️ 8.5 MB (-47.86%)

Largest size changes

Item Install Size Change Download Size Change
🗑 com.google.android ⬇️ -1.2 MB ⬇️ -406.4 kB
🗑 androidx.datastore ⬇️ -607.0 kB ⬇️ -222.2 kB
🗑 androidx.constraintlayout ⬇️ -491.5 kB ⬇️ -174.2 kB
resources.arsc ⬇️ -663.5 kB ⬇️ -121.5 kB
🗑 androidx.appcompat ⬇️ -481.0 kB ⬇️ -103.8 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Copy link

emerge-tools bot commented Jul 8, 2024

📸 Snapshot Test

No snapshots generated


🛸 Powered by Emerge Tools

Copy link
Contributor

@rbro112 rbro112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! For the size check to pass, I think you'll need to update

run: ./gradlew :app:emergeUploadReleasePerfBundle
to be ./gradlew :app:emergeUploadReleaseAab

@Rahkeen Rahkeen merged commit 8c0ee62 into main Jul 9, 2024
3 of 4 checks passed
@Rahkeen Rahkeen deleted the swap-android-repo branch July 9, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants