MediaType.get(s) -> s.toMediaType() #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbro112
approved these changes
May 9, 2024
OkHttp 4 moves MediaType.get to toMediaType (an extension function) See: https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/
chromy
force-pushed
the
hjd/2024-05-09-mediaType
branch
from
4cec519 to
6f6612b
Compare
2 builds increased size
Hacker News 1.0 (1)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 kotlinx.coroutines.YieldKt | ⬇️ -94.6 kB | ⬇️ -43.2 kB |
| 🗑 okio.Base64 | ⬇️ -79.0 kB | ⬇️ -36.1 kB |
| 📝 kotlin.text.UStringsKt | ⬆️ 73.7 kB | ⬆️ 33.6 kB |
| 📝 _COROUTINE._BOUNDARY | ⬆️ 72.7 kB | ⬆️ 33.1 kB |
| 📝 kotlin.ResultKt | ⬆️ 72.5 kB | ⬆️ 33.1 kB |
View Treemap
Hacker News 1.0 (1)
com.emergetools.hackernews.debug
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 694.6 kB (1.17%)
Total download size change: ⬆️ 284.1 kB (1.63%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 okio.internal._BufferKt | ⬆️ 25.5 kB | ⬆️ 9.2 kB |
| publicsuffixes.gz | ⬆️ 4.6 kB | ⬆️ 4.6 kB |
| 📝 okio.internal._ByteStringKt | ⬆️ 12.6 kB | ⬆️ 4.5 kB |
| okio.Buffer | ⬆️ 8.9 kB | ⬆️ 3.2 kB |
| 📝 okio.internal._RealBufferedSourceKt | ⬆️ 8.5 kB | ⬆️ 3.1 kB |
View Treemap
🛸 Powered by Emerge Tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHttp 4 moves MediaType.get to toMediaType (an extension function) See: https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/
@rbro112: could we chat about this quickly at some point? I needed to tweak this to get hn to build recently but I'm not clear on where the version of okhttp is chosen.