Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Screen Preview Fix #166

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Small Screen Preview Fix #166

merged 4 commits into from
Oct 16, 2024

Conversation

Rahkeen
Copy link
Collaborator

@Rahkeen Rahkeen commented Oct 2, 2024

Showcasing fixing our small screen bug in settings by leveraging Previews + Snapshots.

Copy link
Collaborator Author

Rahkeen commented Oct 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Rahkeen and the rest of your teammates on Graphite Graphite

@Rahkeen Rahkeen changed the title Add SmalL Screen Preview to Showcase Settings Bug Add Small Screen Preview to Showcase Settings Bug Oct 2, 2024
@Rahkeen Rahkeen changed the title Add Small Screen Preview to Showcase Settings Bug Small Screen Preview Fix Oct 2, 2024
@Rahkeen Rahkeen marked this pull request as ready for review October 2, 2024 21:09
Copy link

emerge-tools bot commented Oct 2, 2024

📸 Snapshot Test

3 modified, 8 added, 68 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0.1 (10) 8 0 3 68 0 ✅ Approved

🛸 Powered by Emerge Tools

@Rahkeen Rahkeen requested a review from rbro112 October 2, 2024 22:23
Copy link
Collaborator Author

Rahkeen commented Oct 16, 2024

Merge activity

  • Oct 15, 8:09 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 8:09 PM EDT: A user merged this pull request with Graphite.

@Rahkeen Rahkeen merged commit 8a31ead into main Oct 16, 2024
5 checks passed
@Rahkeen Rahkeen deleted the fix-settings-small-screen branch October 16, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants